Bad Smells

We were working on some refactored code today that wasn’t refactored properly. The tests had been changed to make the refactored code pass. My colleague said that I should write-up my “profound” comment on the situation:

If you’re performing a refactoring and you find yourself changing asserts in existing unit tests, something should smell bad. You’ve probably done something more than refactor the code.

Comments are closed.